Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UX-881): Range Selector #217

Merged
merged 5 commits into from
Nov 22, 2024
Merged

feat(UX-881): Range Selector #217

merged 5 commits into from
Nov 22, 2024

Conversation

DE7924
Copy link
Contributor

@DE7924 DE7924 commented Nov 21, 2024

No description provided.

@DE7924
feat: Created Range Selector
001ef48 
test: wrote 1 test for range selector
@DE7924
test: testing range selector
a61045c 
docs: widgetbook and example for range selector
@DE7924
test: created interaction tests
172985e
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

PR Checks complete

  • ✅ - Linting / Formatting
  • ✅ - Static analysis passed
  • ✅ - All tests passed
  • 📈 - Code coverage: 48.25% (⬆️ up from 47.36%)
    See details
    File Name%Passing?
    lib/src/components/stepper_input/stepper_input.dart71.9%⛔️
    lib/generated/tokens/primitives.g.dart31.1%⛔️
    lib/generated/tokens/semantics.g.dart10.7%⛔️
    lib/src/components/accordion/accordion.dart100%✅
    lib/src/utils/rounded.dart100%✅
    lib/src/components/avatar_rail/avatar_rail.dart53.7%⛔️
    lib/src/components/avatars/avatar.dart94.7%✅
    lib/src/components/badges/indicator.dart100%✅
    lib/src/components/badges/label.dart100%✅
    lib/src/components/badges/priority_pill.dart100%✅
    lib/src/components/badges/status_label.dart100%✅
    lib/src/components/badges/tag.dart98.5%✅
    lib/src/components/banner/banner.dart88.4%✅
    lib/src/components/bottom sheets/bottom_sheet.dart0%⛔️
    lib/src/components/bottom sheets/menu_items.dart0%⛔️
    lib/src/components/breadcrumb/breadcrumb.dart86.5%✅
    lib/src/components/button_group/button_group.dart0%⛔️
    lib/src/components/buttons/button.dart97.7%✅
    lib/src/components/buttons/button_style.dart100%✅
    lib/src/components/buttons/icon_button.dart51.2%⛔️
    lib/src/components/buttons/input_icon_button.dart72.7%⛔️
    lib/src/components/chat_item/chat_item.dart98.4%✅
    lib/src/components/checkbox/checkbox.dart100%✅
    lib/src/components/chips/assist_chip.dart0%⛔️
    lib/src/components/chips/chip.dart81.6%✅
    lib/src/components/chips/filter_chip.dart0%⛔️
    lib/src/components/chips/input_chip.dart0%⛔️
    lib/src/components/chips/status_chip.dart90.9%✅
    lib/src/components/comms_button/comms_button.dart82%✅
    lib/src/components/contact_item/contact_item.dart0%⛔️
    lib/src/components/date_input/date_input.dart0%⛔️
    lib/src/components/dial_pad/dial_pad.dart100%✅
    lib/src/components/dialog/dialog.dart0%⛔️
    lib/src/components/dropdown/dropdown.dart0%⛔️
    lib/src/components/fabs/fab.dart96.4%✅
    lib/src/components/filter_selection/filter_selection.dart0%⛔️
    lib/src/components/global_header/global_header.dart0%⛔️
    lib/src/components/global_header/header_tab_item.dart0%⛔️
    lib/src/components/icon/icon.dart100%✅
    lib/src/components/in_page_banner/in_page_banner.dart100%✅
    lib/src/components/list_item/dropdown_list_item.dart0%⛔️
    lib/src/components/list_item/list_item.dart0%⛔️
    lib/src/components/list_item/notification_list_item.dart0%⛔️
    lib/src/components/navigation bar/navigation_bar.dart94.5%✅
    lib/src/components/navigation_rail/navigation_rail.dart0%⛔️
    lib/src/components/pagination/pagination.dart0.6%⛔️
    lib/src/components/password/password_input.dart100%✅
    lib/src/components/phone_input/phone_input.dart0%⛔️
    lib/src/components/progress/progress_bar.dart0%⛔️
    lib/src/components/progress/progress_circle.dart0%⛔️
    lib/src/components/radio/radio.dart0%⛔️
    lib/src/components/range_selector/range_selector.dart84.5%✅
    lib/src/components/screen_header_bar/screen_header_bar.dart0%⛔️
    lib/src/components/search_bar/search_bar.dart98.1%✅
    lib/src/components/segmented_control/segmented_control.dart0%⛔️
    lib/src/components/select_input/select_input.dart0%⛔️
    lib/src/components/slider/slider.dart82.3%✅
    lib/src/components/snack_bar/snack_bar.dart0%⛔️
    lib/src/components/stepper/stepper.dart95.1%✅
    lib/src/components/switch/zeta_switch.dart0%⛔️
    lib/src/components/tabs/tab.dart0%⛔️
    lib/src/components/tabs/tab_bar.dart0%⛔️
    lib/src/components/text_input/text_input.dart0%⛔️
    lib/src/components/time_input/time_input.dart0%⛔️
    lib/src/components/tooltip/tooltip.dart98.9%✅
    lib/src/components/top_app_bar/top_app_bar.dart85.7%✅
    lib/src/interfaces/form_field.dart81.4%✅
    lib/src/components/text_input/internal_text_input.dart72.5%⛔️
    lib/src/components/list_item/list_scope.dart0%⛔️
    lib/src/components/phone_input/countries.dart10%⛔️
    lib/src/components/progress/progress.dart0%⛔️
    lib/src/components/switch/material_switch.dart0%⛔️
    lib/src/components/text_input/hint_text.dart77.8%⛔️
    lib/src/components/text_input/input_label.dart0%⛔️
    lib/src/components/top_app_bar/extended_top_app_bar.dart93.9%✅
    lib/src/components/top_app_bar/search_top_app_bar.dart88%✅
    lib/src/theme/breakpoints.dart100%✅
    lib/src/theme/color_extensions.dart100%✅
    lib/src/theme/color_swatch.dart77.3%⛔️
    lib/src/theme/contrast.dart100%✅
    lib/src/theme/color_scheme.dart100%✅
    lib/src/theme/colors.dart100%✅
    lib/src/theme/theme_data.dart100%✅
    lib/src/theme/tokens.dart50%⛔️
    lib/src/utils/debounce.dart100%✅
    lib/src/utils/extensions.dart100%✅
    lib/src/utils/nothing.dart100%✅
    lib/src/utils/platform/platform_is.dart10%⛔️
    lib/src/utils/platform/universal_platform_vm.dart21.4%⛔️
    lib/src/utils/zeta.dart97.8%✅
    lib/src/utils/zeta_provider.dart100%✅

Created with Flutter code quality action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 9b356bc):

https://zeta-flutter-main--pr-217-feat-ux-881-range-selector-n4fk1nr7.web.app

(expires Fri, 29 Nov 2024 09:54:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5ca681de0a0ad9185b252304c113355d5ee04ca6

thelukewalton
thelukewalton approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@thelukewalton thelukewalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is a really complicated component. Well done!

test/src/components/range_selector/range_selector_test.dart Show resolved Hide resolved
example/widgetbook/pages/components/range_selector_widgetbook.dart Outdated Show resolved Hide resolved
lib/src/components/range_selector/range_selector.dart Outdated Show resolved Hide resolved
lib/src/components/range_selector/range_selector.dart Outdated Show resolved Hide resolved
@DE7924
fix: removed rounded from widgetbook
9b356bc 
fix: removed large thumbs

fix: removed defaults to true on showValues
@DE7924 DE7924 merged commit 7257c40 into main Nov 22, 2024
4 checks passed
@thelukewalton thelukewalton mentioned this pull request Nov 22, 2024
Merged
@DE7924 DE7924 deleted the feat(UX-881)-range-selector branch November 22, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelukewalton thelukewalton thelukewalton approved these changes

@benken benken Awaiting requested review from benken benken is a code owner

@mikecoomber mikecoomber Awaiting requested review from mikecoomber mikecoomber is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DE7924 @thelukewalton